Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Project Management: Change method name in description #28818

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ruben-vl
Copy link
Contributor

Because

The description refers to the above-mentioned method as 'foo', while the example uses a method called 'food_opinion'. Probably wasn't changed when changing the example to something more descriptive.

This PR

  • Fixes the method name in the description

Issue

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby Involves the Ruby course label Sep 20, 2024
@ruben-vl
Copy link
Contributor Author

The MarkDownLint check fails, but I cannot figure out what causes it. I checked the preview tool and the style guide, but cannot find issues there. My assumption is that the underscore creates a problem, but I don't see any details on why the check failed.

@CouchofTomato CouchofTomato merged commit 3dc78a1 into TheOdinProject:main Sep 20, 2024
2 of 3 checks passed
@MaoShizhong
Copy link
Contributor

The MarkDownLint check fails, but I cannot figure out what causes it. I checked the preview tool and the style guide, but cannot find issues there. My assumption is that the underscore creates a problem, but I don't see any details on why the check failed.

Looks like there's an error in how the lint actions were filtering paths (it used the wrong workflow which then led to it running the linter with no file path, hence the output showing the --help display instead. I'll see if I can get a fix in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants