Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Up A React Environment: Update import explanations of main.jsx #28697

Merged

Conversation

Legalunicorn
Copy link
Contributor

Removed mentions of importing React and ReactDOM directly.

Because

Updated the import explanation to match the boilerplate code generated by Vite in the newer version.

This PR

  • ReactDOM.createRoot becomes createRoot
  • React and ReactDOM removed as imports, changed to StrictMode and createRoot

Issue

Closes #28680

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Removed mentions of importing React and ReactDOM directly.
@github-actions github-actions bot added the Content: React Involves the React course label Aug 24, 2024
@mathdebate09
Copy link
Contributor

Yayy 🚀

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@MaoShizhong MaoShizhong merged commit 8f7ec26 into TheOdinProject:main Aug 24, 2024
3 checks passed
@Legalunicorn
Copy link
Contributor Author

Thanks for the opportunity @MaoShizhong :-) Its a very tiny contribution to the lesson but it has been great learning experience for me. Cheers 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactJS: Update boilerplate code generated by vite in main.jsx
3 participants