Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS Deployment Lesson: Update Render free plan informations #28671

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

NestorNebula
Copy link
Contributor

Because

The Lessons says that Render's Free Plan requires a credit card but it not this is not the case currently.

This PR

This PR:

  • Updates informations about the Render Free Plan in the NodeJS Course, Express Section, Deployment Lesson.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Render Free Plan actually doesn't requires a credit card.
@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Aug 20, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - can confirm the free plan doesn't seem to need a credit card currently to deploy. Could you also make the same change to the Ruby on Rails deployment lesson please? You can just push the change to this branch to add it to this PR.

@NestorNebula
Copy link
Contributor Author

After reading the Render paragraph in the Ruby on Rails course, it doesn't refer to the need of a credit so I don't think that there is a change to do. Tell me if I am wrong.

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I must have misread. Thanks for fixing this!

@MaoShizhong MaoShizhong merged commit 81c3db9 into TheOdinProject:main Aug 26, 2024
3 checks passed
@NestorNebula
Copy link
Contributor Author

Thanks, this was my first PR, a little change of course but I am happy to have contributed!

@NestorNebula NestorNebula deleted the patch-1 branch August 26, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants