Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms and Data Handling: Remove asyncHandler references #28567

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

royalh23
Copy link
Contributor

@royalh23 royalh23 commented Aug 4, 2024

Because

The lesson uses asyncHandler for controllers; however, it is unnecessary since there isn't any async operation involved in the examples.

This PR

  • Removes all asyncHandler references in the examples

Issue

Closes #XXXXX

Additional Information

Related Discord discussion: https://discord.com/channels/505093832157691914/597796701650026517/1269659544900866069

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Aug 4, 2024
@royalh23 royalh23 changed the title Remove asyncHandler references Forms and Data Handling: Remove asyncHandler references Aug 4, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that none of the examples here use async ops, the removals make sense. And yes, asyncHandler wouldn't be involved with the form validation result. Thanks for spotting this and making the change.

@MaoShizhong MaoShizhong merged commit 21ffd78 into TheOdinProject:main Aug 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants