Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing JavaScript: Necessary changes in testing module of javascript #28560

Merged
merged 7 commits into from
Aug 4, 2024

Conversation

AnkitAdhikari
Copy link
Contributor

Because

This resolves the problem of not getting to follow along the previous video of assignment 1 from funfunfunction which API has turned out to be paid and this provides new assignment video to follow. Also made some indentation fixes in last paragraph of More Testing's assignment and removes the irrelevant last sentence of 2nd assignment of Testing Basics.

This PR

  • Replace video of 1st assignment in More Testing
  • Adds extra 1 space to maintain 3 spaces indentation (previously was 2 spaces) on 5th assignment step of More Testing.
  • Removes 2nd assignment last paragraph.

Issue

Closes #28379

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Aug 3, 2024
javascript/testing_javascript/more_testing.md Outdated Show resolved Hide resolved
javascript/testing_javascript/more_testing.md Outdated Show resolved Hide resolved
AnkitAdhikari and others added 4 commits August 4, 2024 15:54
Co-authored-by: MaoShizhong <[email protected]>
update necessary changes from upstrem to my local dev_branch
… dev_branch

merging resolved commit from PR discussion
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated!

@MaoShizhong MaoShizhong merged commit a4ff571 into TheOdinProject:main Aug 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
2 participants