Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJs Forms and Data Handling: Fix createUser path #28544

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

jimmyli123
Copy link
Contributor

Because

The createUser path is incorrect. Fix the createUser path link by removing "users"

This PR

  • Remove the "/users" from the "/users/create/" path

Issue

Closes #28538

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Aug 1, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Would you mind also doing the exact same.for the very first code block of the lesson? Missed that one too. Even though it's technically not part of the code-along bit, it's still nice to have it consistent with that part. Much appreciated!

@jimmyli123
Copy link
Contributor Author

Thanks for fixing this. Would you mind also doing the exact same.for the very first code block of the lesson? Missed that one too. Even though it's technically not part of the code-along bit, it's still nice to have it consistent with that part. Much appreciated!

Yeah of course! The routes also had the same issue, let me add those

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated!

@MaoShizhong MaoShizhong merged commit 3265b6c into TheOdinProject:main Aug 1, 2024
3 checks passed
@jimmyli123 jimmyli123 deleted the fixCreateUserPath branch August 1, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forms and Data Handling: createUser path is incorrect
2 participants