Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails basics : Change link texts #28371

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

forge34
Copy link
Contributor

@forge34 forge34 commented Jul 9, 2024

Because

Change link text in some lessons in rails basics

This PR

  • Routing lesson : change link text in line 212
  • Blog app project : change link text in line 25
  • Deployment lesson : change link text in lines 107 ,108 ,127 ,128 , 147 , 148 ,168 and 169

Issue

Related to #28290

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Jul 9, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting these links sorted, @forge34.

Would you also be happy to fix the lint errors in routing and project_blog_app?
You should be able to sort most if not all of the errors in those files by following our local linting and fixing instructions, using the appropriate lesson/project scripts.

If you run into any issues with this, or there are any unfixable lint errors that need context-based manual fixing, let me know.

@forge34
Copy link
Contributor Author

forge34 commented Jul 9, 2024

Thanks for getting these links sorted, @forge34.

Would you also be happy to fix the lint errors in routing and project_blog_app? You should be able to sort most if not all of the errors in those files by following our local linting and fixing instructions, using the appropriate lesson/project scripts.

If you run into any issues with this, or there are any unfixable lint errors that need context-based manual fixing, let me know.

sure : )
just to make sure i can either use option 1 or 2 , or just option 2? from the link

edit : i used option 2 , seems to be done : ) i think

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Like with eslint/prettier, the VSCode extension just makes things more convenient by showing live error highlighting etc.
The best thing for actually seeing lint error details and fixing is to use the npm package and our scripts. So I handle large quantities of lint issues via the the npm scripts, but also have the extension because it makes things convenient when you're making changes, as you see squigglies in real-time.

@MaoShizhong MaoShizhong merged commit 6a8d202 into TheOdinProject:main Jul 9, 2024
3 checks passed
@forge34 forge34 deleted the update-link-text branch July 9, 2024 18:01
@forge34
Copy link
Contributor Author

forge34 commented Jul 9, 2024

🚀

Like with eslint/prettier, the VSCode extension just makes things more convenient by showing live error highlighting etc. The best thing for actually seeing lint error details and fixing is to use the npm package and our scripts. So I handle large quantities of lint issues via the the npm scripts, but also have the extension because it makes things convenient when you're making changes, as you see squigglies in real-time.

i see , from now on i have the extension and will continue using the npm scripts to fix and check if there is any errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants