-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails basics : Change link texts #28371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting these links sorted, @forge34.
Would you also be happy to fix the lint errors in routing
and project_blog_app
?
You should be able to sort most if not all of the errors in those files by following our local linting and fixing instructions, using the appropriate lesson/project scripts.
If you run into any issues with this, or there are any unfixable lint errors that need context-based manual fixing, let me know.
sure : ) edit : i used option 2 , seems to be done : ) i think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Like with eslint/prettier, the VSCode extension just makes things more convenient by showing live error highlighting etc.
The best thing for actually seeing lint error details and fixing is to use the npm package and our scripts. So I handle large quantities of lint issues via the the npm scripts, but also have the extension because it makes things convenient when you're making changes, as you see squigglies in real-time.
i see , from now on i have the extension and will continue using the npm scripts to fix and check if there is any errors |
Because
Change link text in some lessons in rails basics
This PR
Issue
Related to #28290
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section