Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Ruby : Changed some descriptive link texts #28363

Merged

Conversation

LAKSHYA201
Copy link
Contributor

Because

To improve accessibility , certain link texts in various lessons were required to be revamped.

This PR

  • Changes in a link text in line 671 of pattern_matching.md
  • Changes in various link texts of blocks.md
  • Changes in a link text in line 45 of project_custom_enumerables.md

Issue

Related to #28290

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby Involves the Ruby course label Jul 8, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nit below.

Would you also be comfortable fixing the remaining lint errors in the files for blocks and pattern_matching? I believe those errors should be fixable via our auto-fix scripts - you can follow our instructions for linting and fixing locally. You may need to run the fix:lesson script more than once on each of those files to catch and resolve all the errors.

Let me know if you run into any issues with this!

ruby/advanced_ruby/pattern_matching.md Outdated Show resolved Hide resolved
@MaoShizhong MaoShizhong merged commit fa1cf4d into TheOdinProject:main Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants