Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installations: Add bullet-point to Stage 4 addressing issue #28325 #28351

Closed

Conversation

MidlifeMechanicus
Copy link
Contributor

@MidlifeMechanicus MidlifeMechanicus commented Jul 7, 2024

Because

This PR addresses the issues raised in #28325. Specifically, it clarifies that copy pasting should happen in the VM.

This PR

  • Add bullet-point to Step 4 of VM installation instructing user to reopen TOP in VM browser, with explanation.

Issue

Closes #28325

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Jul 7, 2024
@MidlifeMechanicus
Copy link
Contributor Author

I saw the linting issue flagged up by the auto-checker and have fixed it. One of the headings had too many hash-marks.

@MidlifeMechanicus
Copy link
Contributor Author

The linting issue has been thrown up again. It wants a specific heading (### Lesson overview) in place of the warning that is being offered. I think that this might be a case where the default structure does not fit the needs of the lesson.

That being the case, it may well be more appropriate for my final commit NOT to be included (the smaller heading size would be appropriate). I leave that in the hands of the reviewer.

If anything more is required on my end, just let me know.

@MaoShizhong
Copy link
Contributor

Thanks for this PR.
Unfortunately, I'll be closing this PR without merging, as you had not yet been assigned to the linked issue, and someone else had requested assignment before you.

As per our contributing guide (and is also a standard OSS contributing practice), you should not open a PR for an open issue if you have not been assigned by a maintainer.

@MaoShizhong MaoShizhong closed this Jul 7, 2024
@MidlifeMechanicus MidlifeMechanicus deleted the 28325 branch July 8, 2024 07:03
@MidlifeMechanicus MidlifeMechanicus restored the 28325 branch July 8, 2024 07:03
@MidlifeMechanicus MidlifeMechanicus deleted the 28325 branch July 8, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installations: Clarify that copy pasting should happen in the VM
2 participants