Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data structures algorithms #28339

Merged

Conversation

peter-bachowski
Copy link
Contributor

Because

Change the position of four links in the Assignment section, as well as one link in the Additional Resources section. Also, remove one link from the Additional Resources section.

This PR

  • Change link placement from [this video] to [Coursera’s Algorithms course].
  • Change link placement from [this video] to [how binary search works].
  • Change link placement from [this video] to [how a binary search tree is constructed from an unordered array].
  • Change link placement from [this video] to [principles of queues and stacks].
  • Delete line: [An article] that discusses how to construct a binary search tree from an unordered array.
  • Change link placement from [A stack overflow discussion] to [relative strengths of BFS and DFS].

Issue

Related to #28290

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby Involves the Ruby course label Jul 4, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @peter-bachowski
There's just the one required change detailed in the comment below.

Optional: There are some linting errors in this lesson file (not introduced by you). While we're at it, would you be happy to fix them after you've made the required change? If so, let me know when you're done with the lint fixes, otherwise let me know if not so I know not to expect them.

If you were happy to fix the linting errors, we have instructions for linting and fixing locally you can follow. I think in this instance, you'd need to run the fix:lesson script twice to catch and fix all the errors.

ruby/computer_science/common_data_structures_algorithms.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MaoShizhong MaoShizhong merged commit 5b163e0 into TheOdinProject:main Jul 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants