Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installations: Add chrome shortcuts in additional resources section #28329

Merged

Conversation

TheSeagullDev
Copy link
Contributor

Because

  • Adds a link to Google Chrome shortcuts in installations lesson

This PR

  • Adds one additional resource with a link to common Google Chrome shortcuts for Mac and Linux

Issue

Closes #28236

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Jul 2, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTIONAL: If you're happy to do so, could you also follow our local linting and fixing instructions and run the fix:lesson script twice on the installations file to fix up some of the "surrounding blank lines" linting errors? There will still be an error at the end about "required heading structure" that you can ignore.

foundations/installations/installations.md Outdated Show resolved Hide resolved
@TheSeagullDev
Copy link
Contributor Author

@MaoShizhong I addressed the link text and also passed the lesson through the linter, let me know if anything further is needed.

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for contributing.

@MaoShizhong MaoShizhong merged commit 6f7efc0 into TheOdinProject:main Jul 2, 2024
2 of 3 checks passed
@TheSeagullDev TheSeagullDev deleted the chrome-keyboard-shortcuts branch July 3, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installations: Add a link to Chrome keyboard shortcuts in additional resources
2 participants