-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby: Provide descriptive link text #28322
Ruby: Provide descriptive link text #28322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this @TheSeagullDev.
Would you be happy to fix the remaining linting errors across the three files? This should be doable by following our instructions on linting and fixing locally (it's possible that some lines with multiple auto-fixable errors might need more than one run of a fix script to capture everything).
If you're happy to do this, let me know once you've finished pushing those fixes. Likewise, let me know if you're not comfortable doing this, and I can merge this PR as is.
@MaoShizhong Linting errors have been fixed (hopefully, I'm still in JS foundations). Let me know if I need to fix anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one fix below but otherwise we should be good to go afterwards! 🚀
Co-authored-by: MaoShizhong <[email protected]>
@MaoShizhong The fix should be added now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Because
Makes link text more descriptive
This PR
Update link text in
Issue
Related to #28290
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section