Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Provide descriptive link text #28322

Merged

Conversation

TheSeagullDev
Copy link
Contributor

Because

Makes link text more descriptive

This PR

Update link text in

  • debugging.md
  • basic_enumerable_methods.md
  • predicate_enumerable_methods.md

Issue

Related to #28290

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby Involves the Ruby course label Jul 1, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this @TheSeagullDev.

Would you be happy to fix the remaining linting errors across the three files? This should be doable by following our instructions on linting and fixing locally (it's possible that some lines with multiple auto-fixable errors might need more than one run of a fix script to capture everything).

If you're happy to do this, let me know once you've finished pushing those fixes. Likewise, let me know if you're not comfortable doing this, and I can merge this PR as is.

@TheSeagullDev
Copy link
Contributor Author

@MaoShizhong Linting errors have been fixed (hopefully, I'm still in JS foundations). Let me know if I need to fix anything.

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one fix below but otherwise we should be good to go afterwards! 🚀

ruby/basic_ruby/basic_enumerable_methods.md Outdated Show resolved Hide resolved
@TheSeagullDev
Copy link
Contributor Author

@MaoShizhong The fix should be added now

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MaoShizhong MaoShizhong merged commit f4eb663 into TheOdinProject:main Jul 4, 2024
3 checks passed
@TheSeagullDev TheSeagullDev deleted the ruby-descriptive-links branch July 25, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants