-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Methods lesson: Provide descriptive link text #28310
Methods lesson: Provide descriptive link text #28310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing these and also fixing up the lint errors. Just a couple of small changes below then we should be good to merge!
I think I got everything. I had some problems trying to squash the new commit into the old one but I think I got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Congrats on your first PR here
Thank you |
Do I delete the branch then? |
You can safely delete the branch now that it's been merged. |
Because some links in the lesson were either too verbose or too concise. These changes make the lesson easier to follow
This PR
Issue
Related to #28290
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section