-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(foundations/variables and operators): add several examples and clarify a few points #27624
feat(foundations/variables and operators): add several examples and clarify a few points #27624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry about the delay. It looks like the file has been edited a bit in the meantime as well.
Could you re-request a review when the merge conflicts have been solved? I'll try to find some time for the review soon.
I've resolved the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, please address my comments and we will take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, just a few more small suggestions
Co-authored-by: Alex Younger <[email protected]>
Co-authored-by: Alex Younger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
Because
Lesson could see some improvement. This is the first lesson where learners are introduced to javascript. It should be a lot more beginner-friendly
A lot of these changes are subjective. Feel free to suggest certain changes to be reverted.
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section