Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(foundations/variables and operators): add several examples and clarify a few points #27624

Merged
merged 30 commits into from
Aug 21, 2024

Conversation

NikitaRevenco
Copy link
Contributor

@NikitaRevenco NikitaRevenco commented Mar 17, 2024

Because

Lesson could see some improvement. This is the first lesson where learners are introduced to javascript. It should be a lot more beginner-friendly

A lot of these changes are subjective. Feel free to suggest certain changes to be reverted.

This PR

  • Grouped / removed many points in the Learning outcomes
    • I believe the current list is too long and could be intimidating to someone who has never heard about javascript before
  • Added a few examples here and there
  • Removed paragraph talking about the fact that JS can be run outside of browser
    • Learners wouldn't even know that it is possible to do so. Adds unnecessary complexity in my opinion
  • Lesson overview items are now statements instead of questions
  • Instructions on how to open the dev tools are improved
  • Moved many things to assignment
  • Removed an additional resource relating to var
    • learners would not know about scope, functions or control flow at this point
  • Many other small improvements

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@NikitaRevenco NikitaRevenco marked this pull request as draft March 17, 2024 11:28
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Mar 17, 2024
@NikitaRevenco NikitaRevenco marked this pull request as ready for review March 17, 2024 16:34
@NikitaRevenco NikitaRevenco changed the title Variables and Operators: improve lesson Variables and Operators: Improve lesson Mar 17, 2024
@CouchofTomato CouchofTomato requested review from a team and ManonLef and removed request for a team March 18, 2024 14:09
Copy link
Member

@ManonLef ManonLef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NikitaRevenco

I'm sorry about the delay. It looks like the file has been edited a bit in the meantime as well.
Could you re-request a review when the merge conflicts have been solved? I'll try to find some time for the review soon.

@NikitaRevenco NikitaRevenco requested a review from ManonLef June 25, 2024 09:44
@NikitaRevenco
Copy link
Contributor Author

I've resolved the conflicts

@NikitaRevenco NikitaRevenco changed the title Variables and Operators: Improve lesson feat(foundations/variables and operators): add several examples and clarify a few points Aug 9, 2024
@KevinMulhern KevinMulhern requested review from ManonLef, a team, bycdiaz, fortypercenttitanium and thatblindgeye and removed request for a team, ManonLef, bycdiaz and fortypercenttitanium August 18, 2024 09:22
Copy link
Contributor

@fortypercenttitanium fortypercenttitanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, please address my comments and we will take another look.

Copy link
Contributor

@fortypercenttitanium fortypercenttitanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, just a few more small suggestions

Copy link
Contributor

@fortypercenttitanium fortypercenttitanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@fortypercenttitanium fortypercenttitanium merged commit 5783361 into TheOdinProject:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants