Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natural Responsiveness Adv. HTML / CSS: Information behind a separate link #27149

Merged

Conversation

rosecodez
Copy link
Contributor

@rosecodez rosecodez commented Jan 18, 2024

Because

The link on the page could be easily missed by user, therefore adding a note that tells the user to make sure to read the page is a good solution.

This PR

  • adds a note around this link that tells users that they should read the page's text content

Issue

Closes #27123

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course label Jan 18, 2024
kamranzafar4343

This comment was marked as off-topic.

kamranzafar4343

This comment was marked as off-topic.

@rosecodez rosecodez changed the title Information-behind-a-separate-link Natural Responsiveness Adv. HTML / CSS: Information behind a separate link Jan 19, 2024
@JoshDevHub JoshDevHub self-requested a review January 23, 2024 20:50
@JoshDevHub JoshDevHub self-assigned this Jan 23, 2024
@JoshDevHub
Copy link
Contributor

Hi @rosecodez

Would you be up for fixing the linting errors in this file? You didn't introduce any of them, and I know this was supposed to be a very simple fix, so "no" is an acceptable answer. But figured I'd offer you the opportunity if you wanted it.

@rosecodez
Copy link
Contributor Author

On it!

@rosecodez
Copy link
Contributor Author

@JoshDevHub all the errors look good. Love working with the markdown lint error tool :-) having fun with it, thanks!

Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🚀

@JoshDevHub JoshDevHub merged commit 81a236e into TheOdinProject:main Jan 24, 2024
3 checks passed
@rosecodez rosecodez deleted the Information-behind-a-separate-link branch January 28, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Natural Responsiveness Adv. HTML / CSS: Information behind a separate link
3 participants