Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fundamentals-1.md #26514

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

Tclack88
Copy link
Contributor

change max to MAX (as it was the constant specified in the tutorial). If this was done intentionally to implicitly show that variable names are case-sensitive, then this is understandable, but it seems unintentional here.

Because

Reason: avoid any confusion for new programmers by staying consistant with the variable naming

This PR

  • changed all occurences of max to MAX (2 occurences)

Issue

No associated issue

Additional Information

No additional information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

change `max` to `MAX` (as it was the constant specified in the tutorial). If this was done intentionally to implicitly show that variable names are case-sensitive, then this is understandable, but it seems unintentional here.
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Oct 16, 2023
Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@wise-king-sullyman wise-king-sullyman merged commit 90e81a1 into TheOdinProject:main Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants