Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced Forms: Fix layout style #26509

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Advanced Forms: Fix layout style #26509

merged 1 commit into from
Oct 16, 2023

Conversation

Maheshkumar-novice
Copy link
Contributor

Because

Lesson layout not in sync with Layout style guide

This PR

  • Updates the lesson to follow layout style guide

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Oct 16, 2023
@Maheshkumar-novice Maheshkumar-novice changed the title Update advanced_forms lesson to reflect layout style guide Advanced Forms: Fix layout style Oct 16, 2023
wise-king-sullyman
wise-king-sullyman approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@wise-king-sullyman wise-king-sullyman merged commit e1cca63 into TheOdinProject:main Oct 16, 2023
2 checks passed
@Maheshkumar-novice Maheshkumar-novice deleted the patch-7 branch October 17, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

Assignees
No one assigned
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maheshkumar-novice @wise-king-sullyman