Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS/Authentication - Update authentication_basics.md #26505

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

WillAvatec
Copy link
Contributor

@WillAvatec WillAvatec commented Oct 15, 2023

Because

The stated way to set the connection to MongoDB with mongoose in the lesson is outdated as per this link:

https://mongoosejs.com/docs/migrating_to_6.html#no-more-deprecation-warning-options

The docs shows that the options were deprecated on Mongoose 6, since we're in version 7. I'm assuming we're long past that point.

Additional Information

Lesson link: https://www.theodinproject.com/lessons/nodejs-authentication-basics#set-up

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Oct 15, 2023
Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a needed change to me, thanks!

@wise-king-sullyman wise-king-sullyman merged commit 15469b6 into TheOdinProject:main Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants