Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundations - Fundamentals Part 1: Change const variable to uppercase. #26503

Conversation

pulgamecanica
Copy link
Contributor

💡 Why? Because...

As described in this section, when we review variables and naming conventions we learnt that constant variables can be UPPER_CASE or lower_case.
Depending if the value is obtained on run time (then it's lower case) or if the value is a hard coded value, we should use upper case.
Const Naming Conventions

To keep the curriculum in line to what was described on the lesson, I think all the assignments and examples should implement the best practices to make the code more congruent.

This PR

  • changed the hard coded variable to upper case on the assignment 5.

Additional info

Foundations Course - Fundamentals Part 1 (quick link)

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Oct 15, 2023
@pulgamecanica pulgamecanica changed the title Change the variable to uppercase, it's a hard coded constant value. Foundations - Fundamentals Part 1: Change const variable to uppercase. Oct 15, 2023
Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wise-king-sullyman wise-king-sullyman merged commit 92787d2 into TheOdinProject:main Oct 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants