Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Lessons: Update notes #26445

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

Mclilzee
Copy link
Member

@Mclilzee Mclilzee commented Oct 7, 2023

Because

TOP has moved to start using a new lesson-note class to display notes.

This PR

  • Update old (__note: syntax found with the new div class lesson-note in foundation/installation
  • Update note in database_and_sql
  • Moves the link to visualize the database query to after the text explanation rather than before it

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added Content: Databases Involves the Databases course Content: Foundations Involves the Foundations content labels Oct 7, 2023
@ManonLef ManonLef requested a review from thatblindgeye October 7, 2023 20:00
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one change below

foundations/installations/installations.md Outdated Show resolved Hide resolved
Co-authored-by: Eric Olkowski <[email protected]>
@Mclilzee
Copy link
Member Author

Mclilzee commented Oct 9, 2023

@thatblindgeye Thanks for the changes! I have merged it. I wasn't quite sure if you get notified when that happens, so I'm mentioning you for an update.

@thatblindgeye thatblindgeye merged commit 6412a82 into TheOdinProject:main Oct 9, 2023
1 check passed
@Mclilzee Mclilzee deleted the update-notes branch January 9, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Databases Involves the Databases course Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants