Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open links in new tabs #26443

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Open links in new tabs #26443

merged 3 commits into from
Oct 7, 2023

Conversation

jwhudnall
Copy link
Contributor

Because

2 external links don't conform to the convention of opening in a new tab, and overwrite the current one. Opening these in new tabs should improve the reader's experience.

This PR

  • Update URL reference syntax for 2 external link references (from anchor tags to bracket/parenthesis notation).

Issue

N/A

Additional Information

N/A

Pull Request Requirements

  • [x ] I have thoroughly read and understand The Odin Project Contributing Guide
  • [ x] The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • [ x] The Because section summarizes the reason for this PR
  • [ x] The This PR section has a bullet point list describing the changes in this PR
  • [ x] If this PR addresses an open issue, it is linked in the Issue section
  • [ x] If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • [ x] If any lesson files are included in this PR, they follow the Layout Style Guide

2 external links don't conform to the convention of opening in a new tab, and overwrite the current one. Opening these in new tabs should improve the reader's experience.
@github-actions github-actions bot added the Content: React Involves the React course label Oct 7, 2023
@ManonLef
Copy link
Member

ManonLef commented Oct 7, 2023

I see you've checked the requirement of previewing with our markdown preview tool. However, in that tool, it doesn't render correctly. That specific link is inside a div note element, hence why we have to use the a with href. Do you want to revert this and fix the a element link opening behaviour instead?

Screenshot 2023-10-07 at 21 50 38

@ManonLef ManonLef self-requested a review October 7, 2023 19:53
@ManonLef
Copy link
Member

ManonLef commented Oct 7, 2023

Thank you for the quick follow up and this PR!

@ManonLef ManonLef merged commit 6214034 into TheOdinProject:main Oct 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants