Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Up A React Environment: Add note on setting up react in existing repo #26436

Closed
wants to merge 2 commits into from

Conversation

s-hens
Copy link
Contributor

@s-hens s-hens commented Oct 6, 2023

Because

In previous lessons, students are always encouraged to follow a workflow that starts with creating a repo on GitHub, cloning it, working on it locally, and pushing changes often. Adding a note on how to set up a react environment in an existing repo will encourage students to keep using version control best practices while learning React, and minimize confusion over how to do it.

This PR

  • Adds a note on how to set up a React environment in an existing directory
  • Reminds students that a React environment can be set up in a repo cloned from GitHub
  • Encourages the continued use of version control during the React lessons

Issue

n/a

Additional Information

I was motivated to suggest this change because I was confused during this lesson. I turned to Google for information on how to use React in combination with my existing GitHub workflow. I ended up getting a helpful answer on the TOP Discord, but I believe this information should simply be included in the lesson.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: React Involves the React course label Oct 6, 2023
@ManonLef
Copy link
Member

ManonLef commented Oct 6, 2023

Thanks for the suggestion. However, it looks like you've edited an old lesson or your branch is not up to date. We don't use create-react-app anymore. So if you wish to edit the new React content, it needs to be in the updated React course lesson

I think at this point in the curriculum, it's good if people have knowledge on how to go from local to remote as well. I do think at this point we can also safely assume that people that need this, will know how to find the instructions for this online. Spending time in the Discord, I haven't really come across people running into issues from starting a React app locally.

A while back I added an additional resource about going from a local repo to remote in the Git Basics Foundation lesson.

My suggestion would be that if you wish to include anything about adding a React environment to an existing project/local repo, it would only be a note on the command that's needed to initialise it inside the repo. I really don't think at this point in the curriculum we should even have to mention Github and the cloning step.

@ManonLef ManonLef self-assigned this Oct 6, 2023
@ManonLef ManonLef self-requested a review October 6, 2023 12:41
@s-hens
Copy link
Contributor Author

s-hens commented Oct 6, 2023

Thanks for the constructive feedback, and my apologies! In light of the additional resource you added, I can see how this note may not be needed.

@s-hens s-hens closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants