Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fmt version from 9.1.0 to 10.2.1 #185

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

zen-is
Copy link
Contributor

@zen-is zen-is commented Feb 21, 2024

Basically, fmt on 9.1.0 produces a lot of errors on the windows ci context.

For example:

D:\a\dist\dist\cpm_modules\fmt\5c4bc51f3df5bb907a0028facff05ba4978aa6e5\include\fmt\format.h(490,51): 
    warning C4996: 'stdext::checked_array_iterator<T*>': warning STL4043: stdext::checked_array_iterator, stdext::unchecked_array_iterator, and related factory functions are non-Standard extensions and will be removed in the future. std::span (since C++20) and gsl::span can be used instead. You can define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING or _SILENCE_ALL_MS_EXT_DEPRECATION_WARNINGS to suppress this warning. [D:\a\dist\dist\build\_deps\worker-build\Worker.vcxproj]
  (compiling source file '../../../source/worker.cpp')
  C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.38.33130\include\iterator(1470,1):
  see declaration of 'stdext::checked_array_iterator'

By the way, as there are not _SILENCE_ALL_MS_EXT_DEPRECATION_WARNINGS defined, all the warnings are treated as error.

I discover this issue by fork this starter kit and implement as a base for my own project.

image

The following logs includes the relevant messages and, of course, was solved by an upgrade of FMT.

Anyways, thanks a lot @TheLartians.

@TheLartians
Copy link
Owner

Thanks for raising the issue and updating the library! I wonder why the GitHub CI windows runner didn't catch it before here, but happy to update!

@TheLartians TheLartians merged commit 9f4867a into TheLartians:master Apr 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants