-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding type assertion <string> option to fix issues with typescript type checks #37
Open
julianosam
wants to merge
4
commits into
TheLarkInn:master
Choose a base branch
from
julianosam:typeassertion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.65% (diff: 100%)@@ master #37 diff @@
==========================================
Files 1 1
Lines 17 23 +6
Methods 5 5
Messages 0 0
Branches 3 6 +3
==========================================
+ Hits 16 22 +6
Misses 1 1
Partials 0 0
|
3 similar comments
Current coverage is 95.65% (diff: 100%)@@ master #37 diff @@
==========================================
Files 1 1
Lines 17 23 +6
Methods 5 5
Messages 0 0
Branches 3 6 +3
==========================================
+ Hits 16 22 +6
Misses 1 1
Partials 0 0
|
Current coverage is 95.65% (diff: 100%)@@ master #37 diff @@
==========================================
Files 1 1
Lines 17 23 +6
Methods 5 5
Messages 0 0
Branches 3 6 +3
==========================================
+ Hits 16 22 +6
Misses 1 1
Partials 0 0
|
Current coverage is 95.65% (diff: 100%)@@ master #37 diff @@
==========================================
Files 1 1
Lines 17 23 +6
Methods 5 5
Messages 0 0
Branches 3 6 +3
==========================================
+ Hits 16 22 +6
Misses 1 1
Partials 0 0
|
Would you merge conflicts sorry I'm just getting to this. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript complains about the return type of the require() function once A2 defines the component template field as type string. The correct A2 component annotation should be as follows:
This adds an option to include
typeAssertion
to the require() generation. It supports both passing it as a query paramangular2-template-loader?typeAssertion=true
or the via options plugin supported by Webpack 2. Right now, it leaves the type assertion inclusion defaulted tofalse
. But I think it should be defaulted totrue
in a near future.