Fix more issues found by LGTM

These were overlooked in the last sweep.
TheImmortals · Oct 28, 2018 · 0553f42 · 0553f42
1 parent bd71410
commit 0553f42
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/chat-plugins/thehappyplace.js b/chat-plugins/thehappyplace.js
@@ -31,7 +31,7 @@ exports.commands = {
 			Rooms.global.writeChatRoomData();
 			return;
 		}
-		const quote = target.split('|')[0].replace('"', '');
+		const quote = target.split('|')[0].replace(/"/g, '');
 		const author = target.split('|')[1];
 		if (!quote) return;
 		if (!author) {

diff --git a/mods/gen3/random-teams.js b/mods/gen3/random-teams.js
@@ -10,7 +10,6 @@ class RandomGen3Teams extends RandomGen4Teams {
 	 * @return {RandomTeamsTypes["RandomSet"]}
 	 */
 	randomSet(template, slot, teamDetails = {}) {
-		if (slot === undefined) slot = 1;
 		let baseTemplate = (template = this.getTemplate(template));
 		let species = template.species;
 
@@ -500,7 +499,6 @@ class RandomGen3Teams extends RandomGen4Teams {
 			}
 		}
 
-		item = 'Leftovers';
 		if (template.requiredItems) {
 			item = this.sample(template.requiredItems);
 

diff --git a/tournaments/index.js b/tournaments/index.js
@@ -1039,7 +1039,7 @@ const commands = {
 				if (result.charAt(0) === '1') {
 					connection.popup("Your team is valid for this tournament.");
 				} else {
-					const format = Dex.getFormat(tournament.originalFormat).name.replace(/\[/, '\\[').replace(/\]/, '\\]');
+					const format = Dex.getFormat(tournament.originalFormat).name.replace(/\[/g, '\\[').replace(/\]/g, '\\]');
 					connection.popup(`Your team was rejected for the following reasons:\n\n- ${result.slice(1).replace(/\n/g, '\n- ').replace(new RegExp(format, 'g'), 'this tournament')}`);
 				}
 			});