-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observable parsing/extraction updates #4
base: develop
Are you sure you want to change the base?
Conversation
Hello @kx499 thanks for the PR. Can you please remove the Thanks |
thanks - will do. I'm not real familiar with unit tests, but I'll work up some tests though |
…re. still need to add unit test for new features
… list/dicts for full text
@nadouani made the updates, let me know what you think and if any other updates are needed. |
Any word on this? It's been a few months so I figured I'd check in |
@nadouni is there anything else needed for this? I'm looking to develop/update some analyzers based on this code and was hoping it could either get committed or we could discuss other ways of accomplishing the same |
@kx499 Thanks for the PR ! Could you add a closing '>' after the opening '<' in the following line in extractor.py ? Otherwise the closing angle bracket is captured by the regular expression :
(this is the modified line. If there is a bracket in the URL it may stop capturing the URL early though) Also, @nadouani it'd be fantastic if you could have a look at this or at PR #1 😃 |
This employs both singe value matching and full text extractions (think re.find_all) to support pulling indicators out of bobs of text like email bodies. Additionally it supports indicator validators to assist in removing false positives post regex extraction. It exposes the functions so you can call it separately from an analyzer or automatically from the iterable function. in the iterable function it fist calls check_type, and then if not match it goes on to process the full text regex. This is an iteration of this PR #1