Skip to content

Commit

Permalink
#340 - Add retry mechanism
Browse files Browse the repository at this point in the history
  • Loading branch information
Kamforka committed Sep 26, 2024
1 parent 838948d commit 8689a09
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name = "thehive4py"
description = "Python client for TheHive5"
version = "2.0.0b6"
requires-python = ">=3.8"
dependencies = ["requests>=2.27"]
dependencies = ["requests~=2.27"]
readme = "README.md"
keywords = ["thehive5", "api", "client"]
license = { text = "MIT" }
Expand Down
4 changes: 3 additions & 1 deletion thehive4py/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from thehive4py.endpoints.custom_field import CustomFieldEndpoint
from thehive4py.endpoints.observable_type import ObservableTypeEndpoint
from thehive4py.endpoints.query import QueryEndpoint
from thehive4py.session import TheHiveSession
from thehive4py.session import DEFAULT_RETRY, RetryValue, TheHiveSession


class TheHiveApi:
Expand All @@ -29,13 +29,15 @@ def __init__(
password: Optional[str] = None,
organisation: Optional[str] = None,
verify=None,
max_retries: RetryValue = DEFAULT_RETRY,
):
self.session = TheHiveSession(
url=url,
apikey=apikey,
username=username,
password=password,
verify=verify,
max_retries=max_retries,
)
self.session_organisation = organisation

Expand Down
21 changes: 21 additions & 0 deletions thehive4py/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,24 @@
from typing import Any, Optional, Union

import requests
import requests.adapters
import requests.auth
from urllib3 import Retry

from thehive4py.__version__ import __version__
from thehive4py.errors import TheHiveError

DEFAULT_RETRY = Retry(
total=5,
backoff_factor=1,
status_forcelist=[500, 502, 503, 504],
allowed_methods=["GET", "POST", "PUT", "PATCH", "DELETE"],
raise_on_status=False,
)


RetryValue = Union[Retry, int, None]


class SessionJSONEncoder(jsonlib.JSONEncoder):
"""Custom JSON encoder class for TheHive session."""
Expand All @@ -27,11 +40,13 @@ def __init__(
username: Optional[str] = None,
password: Optional[str] = None,
verify=None,
max_retries: RetryValue = DEFAULT_RETRY,
):
super().__init__()
self.hive_url = self._sanitize_hive_url(url)
self.verify = verify
self.headers["User-Agent"] = f"thehive4py/{__version__}"
self._set_retries(max_retries=max_retries)

if username and password:
self.headers["Authorization"] = requests.auth._basic_auth_str(
Expand All @@ -44,6 +59,12 @@ def __init__(
"Either apikey or the username/password combination must be provided!"
)

def _set_retries(self, max_retries: RetryValue):
"""Configure the session to retry."""
retry_adapter = requests.adapters.HTTPAdapter(max_retries=max_retries)
self.mount("http://", retry_adapter)
self.mount("https://", retry_adapter)

def _sanitize_hive_url(self, hive_url: str) -> str:
"""Sanitize the base url for the client."""
if hive_url.endswith("/"):
Expand Down

0 comments on commit 8689a09

Please sign in to comment.