Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NodeRED template + add TheHive+Cortex+Traefik with TLS docker-compose template #42

Merged
merged 7 commits into from
Jan 13, 2022

Conversation

korteke
Copy link
Contributor

@korteke korteke commented Oct 14, 2021

Fixed URLs and added little bit of documentation

@korteke
Copy link
Contributor Author

korteke commented Oct 14, 2021

Gash, now all the changes are in one PR. But two thing:

  • Fixed NodeRED template
  • Created totally new template for TheHive+Cortex+Traefik with TLS

Yes, there is certificate and corresponding private key in the repo. That self-signed certificate is there because it's easier to test this template if there is all bits&pieces in place.

Fixes #43

@korteke korteke changed the title Fixed NodeRED template Fixed NodeRED template + add TheHive+Cortex+Traefik with TLS docker-compose template Oct 14, 2021
@nadouani
Copy link
Contributor

Hello @korteke Thanks for the PR. I think you can remove the cert file, isn't?

@korteke
Copy link
Contributor Author

korteke commented Oct 19, 2021

@nadouani Yeah, ofc it can be removed. I was just thinking that it would be easier to test if there is everything in place :) but i remove it, then gh’s builtin security scanner does not complain about that cert.

@korteke
Copy link
Contributor Author

korteke commented Oct 19, 2021

Hello @korteke Thanks for the PR. I think you can remove the cert file, isn't?

I removed the certificate & private key. 8b12755

@nadouani nadouani merged commit 78ad149 into TheHive-Project:main Jan 13, 2022
@nadouani
Copy link
Contributor

@all-contributors please add @korteke for code

@allcontributors
Copy link
Contributor

@nadouani

I've put up a pull request to add @korteke! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants