-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed NodeRED template + add TheHive+Cortex+Traefik with TLS docker-compose template #42
Conversation
Gash, now all the changes are in one PR. But two thing:
Yes, there is certificate and corresponding private key in the repo. That self-signed certificate is there because it's easier to test this template if there is all bits&pieces in place. Fixes #43 |
Hello @korteke Thanks for the PR. I think you can remove the cert file, isn't? |
@nadouani Yeah, ofc it can be removed. I was just thinking that it would be easier to test if there is everything in place :) but i remove it, then gh’s builtin security scanner does not complain about that cert. |
@all-contributors please add @korteke for code |
I've put up a pull request to add @korteke! 🎉 |
Fixed URLs and added little bit of documentation