#29 Catch error of MISP_modules loader invocation

TheHive-Project · May 22, 2017 · ef22537 · ef22537
1 parent 2de4fe8
commit ef22537
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/app/services/MispSrv.scala b/app/services/MispSrv.scala
@@ -45,12 +45,14 @@ class MispSrv(
 
   private[MispSrv] val futureList: Future[Seq[MispModule]] = Future {
     if (mispModulesEnabled) {
-      Json.parse(s"$loaderCommand --list".!!)
-        .asOpt[Seq[String]]
-        .getOrElse {
-          logger.warn("MISP modules loader returns invalid data")
+      val moduleNameList = Try(Json.parse(s"$loaderCommand --list".!!).as[Seq[String]]) match {
+        case Success(l) ⇒ l
+        case Failure(error) ⇒
+          logger.error(s"MISP module loader fails", error)
           Nil
-        }
+      }
+
+      moduleNameList
         .map { moduleName ⇒
           moduleName → (for {
             moduleInfo ← Try(Json.parse(s"$loaderCommand --info $moduleName".!!))