Miscellaneous Much-Mneeded Maintenance #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the need to maintain the following spells: - Branding Smite - Elemental Weapon - Heroism - Melf's Acid Arrow - Spirit Guardians See previous commit: 9118077. Note that Spirit Guardians was previously retained as having a better implementation (with included the "affected creature's speed is halved in the area" effect) in DDBI; this decision has been reversed, as the CPR implementation includes a choice of damage types, which the DDBI version does not*. Given the choice of maintaining the DDBI version or getting a comparable CPR version with an alternate feature set, the latter is more attractive. * (Due to the way we're abusing it out of context!)
Sync the latest versions of D&D Beyond Importer's spell implementations. Note that Create Bonfire has been removed; our current implementation is broken, and the latest DDBI implementation relies on a DDBI macro.
The former has been standard for some time. Switch over, such that we can more easily drop our itemacro dependency.
With DAE absorbing itemacro's functionality, this is no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highlights:
dae.macroinstead ofitemacro.macroas the latter is dead