Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5ET-1173 Oversized Longbow baseitem #1932

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

revilowaldow
Copy link
Contributor

Adds a homebrew for the Oversized Longbow as a baseitem supporting declined 5ET-1173

@revilowaldow
Copy link
Contributor Author

revilowaldow commented Dec 12, 2023

Test appears to have failed as the file contains a baseitem and not an item
Suggest revision to the test suite, specifically BrewIndexGenerator._DIR_TO_PRIMARY_PROP to include baseitem and magicvariant as valid for the item folder. Though unsure if this currently works on an all or any assumption?

I can also just chuck it in collection if you'd rather not mess with the tests right now?

Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should go in a nice new baseitem folder, unless there was some reason against that?

@revilowaldow
Copy link
Contributor Author

Works for me

@TheGiddyLimit TheGiddyLimit merged commit 15ab088 into TheGiddyLimit:master Dec 18, 2023
1 check failed
@revilowaldow revilowaldow deleted the 5ET-1173 branch December 18, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants