excludeIf should work with @Content too #49
Conversation
|
Absolutely agreed. Was thinking that the other day! |
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function createExclude($object, $excludeIf) |
There was a problem hiding this comment.
The naming create* looks really weird for a method returning a boolean
There was a problem hiding this comment.
Same as the using of factory. I know.
Unfortunately I don't find another proper endpoint (furthermore PropertyFactory have PropertyPath injection already). It would be wrong if MetadataFactory returns NULL when excludeIf conditions is true. And Metadata object is just set of setters/getters and don't contain logic. Visitor Design Pattern would be redundant here also.
So I need some advice.
There was a problem hiding this comment.
@marapper IMO, you need a new object for this instead of trying to fit it in an existing interface where it does not belong
|
👍 for this PR to be merged |
ExcludeIf affects only on links. In some cases we need omit embedded relations too.
For example:
*@rest\Relation("http://hautelook.com/rels/invitations/reminders",