Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix collection's serialization #27

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix collection's serialization #27

wants to merge 8 commits into from

Conversation

NicolasBadey
Copy link
Contributor

No description provided.

@NicolasBadey
Copy link
Contributor Author

(sorry for commit's name :/)

@stof
Copy link

stof commented Feb 20, 2013

@NicolasBadey you could fix it by amending the commit and forcing the push

@adrienbrault the functional tests are broken when symfony 2.2 deps are installed.

@adrienbrault
Copy link
Contributor

@stof Thks, tests fixed
@NicolasBadey Adding a test to https://github.com/TheFootballSocialClub/FSCHateoasBundle/blob/master/Tests/Functional/Serializer/XmlFormViewSerializerTest.php would be better

adrienbrault
adrienbrault reviewed Mar 3, 2013
View reviewed changes
Tests/Functional/Serializer/XmlFormViewSerializerTest.php

$this->assertXmlElementEquals(<<<XML
<form>
<input type="text" name="form[service][__name__][timeId]" required="required"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, theses should be in an attribute named data-prototype on the root form node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasBadey @stof @adrienbrault