This repository has been archived by the owner on Mar 1, 2021. It is now read-only.
Basic structure of the new website #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @feralcode I think we don't need yarn error log |
webpack wotking with react header component and hero component added compoents added to page removal of yarn-error.log
AnshulMalik
suggested changes
Dec 18, 2018
| "name": "website", | ||
| "version": "1.0.0", | ||
| "main": "index.js", | ||
| "repository": "https://github.com/feralCode/website", |
There was a problem hiding this comment.
we should use the upstream repository here.
| <a | ||
| href="http://en.wikipedia.org/wiki/Open-source_software" | ||
| target="_blank" | ||
| > |
|
|
||
| </ul> | ||
| </main> | ||
| <footer> |
There was a problem hiding this comment.
I think this file needs formatting.
| padding: 0; | ||
| margin: 0; | ||
| //background: #ffded1; /* Old browsers */ | ||
| //background: linear-gradient(135deg, #ffded1 0%,#ffded1 50%,#ffc5af 50%,#ffc5af 100%); /* W3C */ |
There was a problem hiding this comment.
comments? I think we don't need them.
| <input type="text" placeholder={placeholder} autoComplete="off" aria-label="Search box" /> | ||
| <i className="material-icons">search</i> | ||
| </div> | ||
| <img className="bg-image" src="https://images.unsplash.com/photo-1527234639945-70d78416bd7d?ixlib=rb-0.3.5&ixid=eyJhcHBfaWQiOjEyMDd9&s=721783d6df00ea979608158fd776675e&auto=format&fit=crop&w=1319&q=80" alt="jumbotron background" /> |
There was a problem hiding this comment.
I think we'll be fine without this image for now.
| constructor() { | ||
| super(); | ||
| this.state = { | ||
| profileImageURL: 'https://d1r8m46oob3o9u.cloudfront.net/images/home-demo-photo-0c.jpg', |
|
@feralcode any updates on this? |
|
@AnshulMalik The last reaction was 27 days ago. Should we close the pull request? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react + babel + webpack added.
yarn used as package manger
yarn installto install packages in lock filewebpack dev server can be started with
yarn startcommandsass added for styling, more work to be done but didn't want to make PR to large.
Original styling left in Main component in src directory
login state change
footer
#23