Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add me #2726

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add me #2726

wants to merge 2 commits into from

Conversation

somyasinghmalik
Copy link

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

realstealthninja
realstealthninja requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please edit your pull requests so it matches our contribution guidelines

how 505957d
@@ -0,0 +1,604 @@
commit 505957d2e19bbc99db1c23e8ded8a029b4ee4280 (HEAD -> add-me)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file doing?

.github/workflows/awesome_workflow.yml
@@ -44,7 +45,22 @@ jobs:
run: |
git diff DIRECTORY.md
git commit -am "clang-format and clang-tidy fixes for ${GITHUB_SHA::8}" || true
git push origin HEAD:$GITHUB_REF || true
git push origin HEAD:$GITHUB_REF || true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested if this works

@realstealthninja realstealthninja added the requested changes changes required label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja requested changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
requested changes changes required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@somyasinghmalik @realstealthninja