fix: main function bugs #2709
Open
fix: main function bugs #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwinIZ8
requested review from
Panquesito7 and
realstealthninja
as code owners
realstealthninja
requested changes
Aug 18, 2024
| 4, 8, INFINITY, 0, 5, 7, | ||
| INFINITY, 3, 1, 5, 0, INFINITY, | ||
| INFINITY, INFINITY, INFINITY, 7, INFINITY, 0}; | ||
| constexpr int POSITIVE_INFINITY = 99999; |
There was a problem hiding this comment.
why not use numeric_limits<int>::infinty(); from the cmath library?
There was a problem hiding this comment.
numeric_limits::infinty() returns 0
There was a problem hiding this comment.
Ah I forgot infinity only works for floats. What about numeric_limit::max()?
realstealthninja
requested changes
Aug 19, 2024
Comment on lines
+58
to
+65
| constexpr int POSITIVE_INFINITY = 99999; | ||
| std::array<std::array<int, 6>, 6> graph = { | ||
| 0, 4, 1, 4, POSITIVE_INFINITY, POSITIVE_INFINITY, | ||
| 4, 0, 3, 8, 3, POSITIVE_INFINITY, | ||
| 1, 3, 0, POSITIVE_INFINITY, 1, POSITIVE_INFINITY, | ||
| 4, 8, POSITIVE_INFINITY, 0, 5, 7, | ||
| POSITIVE_INFINITY, 3, 1, 5, 0, POSITIVE_INFINITY, | ||
| POSITIVE_INFINITY, POSITIVE_INFINITY, POSITIVE_INFINITY, 7, POSITIVE_INFINITY, 0}; |
There was a problem hiding this comment.
Also this should be moved to a test function outside main
realstealthninja
added
awaiting modification
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed a grammar error and solved a naming error.
Checklist
Notes: