[RFC] Kara: template once
#15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move body of function into run_template function, leaving run_templates simply as a loop wrapper, in order to make `template once` logic simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently more a RFC, but this proposes a sample implementation of
template once.The template line acts as its own input line, thus taking e.g. timing and styles from it, as well as (obviously) all the tags and text.
Currently, main caveat is that the template would double up all text, so
notextis forced—but this breaks any mixins. Anything butmixin linewill not even execute, and those will also put their tags after the template line's content.It would thus seem preferable to instead strip the text parts from the template, but what if the user wants to add tags manually in between?
keeptagscould serve this purpose, possibly. In that case, it should have special behavior ontemplate oncelines, where it would disable all tag generation from the template itself, as those would otherwise be duplicated... but now, what about any code that should be run as well?In short: this is a complex issue, with no clear answers to a lot of questions, but I hope this PR at least gets us going somewhere.