Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature landing page #35

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Feature landing page #35

wants to merge 8 commits into from

Conversation

cgrgx
Copy link
Collaborator

@cgrgx cgrgx commented May 10, 2024

optimized images for performance and change assets from public to src folder

@cgrgx cgrgx self-assigned this May 10, 2024
@cgrgx cgrgx added documentation Improvements or additions to documentation duplicate This issue or pull request already exists labels May 10, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blob1 ?
Can we try to name something generic?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's try to come up with a more generic and descriptive name.
How about we rename to something like backgroundBlogImage or decorativeElementBlob?
I'm open to other suggestions as well. Please feel free to propose alternative names that you think would be more appropriate and descriptive.
I appreciate you taking the time to review the code and provide feedback.
Thank you Sagar.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backgroundBlogImage, would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation duplicate This issue or pull request already exists
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants