Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sept responsive review #56

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Fix/sept responsive review #56

merged 7 commits into from
Sep 22, 2023

Conversation

sdmisra
Copy link
Contributor

@sdmisra sdmisra commented Sep 22, 2023

PR Template

  • [] I have ran all tests (if applicable) and they are passing.

Two tests failing on singleWorld view, but they do not seem critical to fix for this to be merged. They are just old names / expected strings that have changed slightly.

Types of changes made?

  • javascript

What does this PR do?

  • Updates JS for

responsiveness - specifically mobile responsiveness and sizing for arrows, welcome page text, some of the grid preview stuff on browser

Questions/Comments/Relevant Screenshots?

There are still issues present for responsiveness, i wasn't sure how to change the single world view to affect:

modal window on mobile devices appears on top of the world description, same with the arrows involved with the carousels for details

I believe a solution is to change the positioning of the arrows of the details carousel, and the modal itself to attach to the bottom of the screen? We could use absolute positioning and just base things off of the bottom rather than the top when the device is a mobile breakpoint.

I could use help with that specific component to finish up this responsiveness audit!

@sdmisra sdmisra requested a review from Adam-Meza September 22, 2023 03:15
@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
front-end ✅ Ready (Inspect) Visit Preview Sep 22, 2023 3:15am

@Adam-Meza
Copy link
Contributor

yeah the modal positioning is definitely off. I feel like I did some sloppy fix for that when I first wrote it so I can fix that. Thanks for figure out the rest tho

@Adam-Meza Adam-Meza merged commit 25ec1bd into main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants