-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration parsing #20
Conversation
bf381e2
to
c178f69
Compare
50bffa5
to
6b79a73
Compare
This is done as far as possible. It will be touched again for work on #22 though as taking config parameters from the cli is mandatory if the config file is empty. Also, as this feature mainly relies on file system operations and other parts of the program, I do not think that writing unittests is very advisable. |
Add config file validation function
3362d84
to
3f3d82d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have implemented it differently but the code you wrote is fine and as such this PR is LGTM.
Thanks for your review! |
What does this PR change?
There are at least two variables that users need to be able to configure when using netbox-sync:
This PR implements the first stage of adding the ability to configure the program by using a
.nbs-config.toml
file.This file will be located in
etc/opt/.nb-config.toml
and at least consist of the following:Tick the applicable box:
Links
Tracks: #21
Documentation