Merge pull request onflow#6626 from m-Peter/mpeter/fix-evm-trace-id-g…

…eneration

[Flow EVM] Move trace ID generation outside the concurrent path

fvm/evm/debug/tracer.go

@@ -90,6 +90,9 @@ func (t *CallTracer) Collect(txID gethCommon.Hash) {
 	// remove the result
 	delete(t.resultsByTxID, txID)
 
+	// generate the trace ID, outside the go-routine
+	traceID := TraceID(txID, t.blockID)
+
 	// upload is concurrent and it doesn't produce any errors, as the
 	// client doesn't expect it, we don't want to break execution flow,
 	// in case there are errors we retry, and if we fail after retries
@@ -107,7 +110,7 @@ func (t *CallTracer) Collect(txID gethCommon.Hash) {
 					Msg("failed to collect EVM traces")
 			}
 		}()
-		if err := t.uploader.Upload(TraceID(txID, t.blockID), res); err != nil {
+		if err := t.uploader.Upload(traceID, res); err != nil {
 			l.Error().Err(err).
 				Str("traces", string(res)).
 				Msg("failed to upload trace results, no more retries")