Skip to content

Commit

Permalink
bump import-codesign-certs from v1 to v3
Browse files Browse the repository at this point in the history
  • Loading branch information
@Owen3H
Owen3H committed Sep 28, 2024
1 parent 3c37de7 commit 8d04aa0
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 44 deletions.
50 changes: 25 additions & 25 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,23 @@ By default, the action will build and upload the results to github, on a tagged
- Added support for Bun setup. Defaults to `false`.
- Changed `nsis` option so that it must be specified.
- Bumped `upload-artifact`. **v3** -> **@v4**.
- Bumped `import-codesign-certs`. **v1** -> **v3**.
- Bumped `setup-go`. **v4** -> **v5**.
- Bumped `setup-node`. **v3** -> **v4**.
- Bumped `node-version` from **18.x** to **20**. This should stop action warnings.

# Default build
## Default Build
```yaml
- uses: The-Egg-Corp/wails-build-action@v1.2
- uses: The-Egg-Corp/wails-build-action@v1.3
with:
build-name: wailsApp
build-platform: linux/amd64
nsis: false # Set to true to create an installer.
```
## Build with No uploading
## Build without uploading
```yaml
- uses: The-Egg-Corp/wails-build-action@v1.2
- uses: The-Egg-Corp/wails-build-action@v1.3
with:
build-name: wailsApp
build-platform: linux/amd64
Expand All @@ -33,7 +34,6 @@ By default, the action will build and upload the results to github, on a tagged
```
## GitHub Action Options
| Name | Default | Description |
|--------------------------------------|--------------------------|------------------------------------------------------------|
| `build-name` | none, required input | The name of the binary |
Expand All @@ -48,24 +48,22 @@ By default, the action will build and upload the results to github, on a tagged
| `node-version` | `20` | NodeJS version to use |
| `bun-setup` | `false` | Whether to setup Bun |
| `bun-version` | `latest` | Bun version to use |
| `deno-build` | `` | Deno compile command |
| `deno-build` | "" | Deno compile command |
| `deno-working-directory` | `.` | Working directory of your [Deno](https://deno.land/) server|
| `deno-version` | `v1.20.x` | Deno version to use |
| `sign-macos-app-id` | '' | ID of the app signing cert |
| `sign-macos-apple-password` | '' | MacOS Apple password |
| `sign-macos-app-cert` | '' | MacOS Application Certificate |
| `sign-macos-app-cert-password` | '' | MacOS Application Certificate Password |
| `sign-macos-installer-id` | '' | MacOS Installer Certificate ID |
| `sign-macos-installer-cert` | '' | MacOS Installer Certificate |
| `sign-macos-installer-cert-password` | '' | MacOS Installer Certificate Password |
| `sign-windows-cert` | '' | Windows Signing Certificate |
| `sign-windows-cert-password` | '' | Windows Signing Certificate Password |

| `deno-version` | `v1.x` | Deno version to use |
| `sign-macos-app-id` | "" | MacOS Application Certificate ID |
| `sign-macos-apple-password` | "" | MacOS Apple Password |
| `sign-macos-app-cert` | "" | MacOS Application Certificate |
| `sign-macos-app-cert-password` | "" | MacOS Application Certificate Password |
| `sign-macos-installer-id` | "" | MacOS Installer Certificate ID |
| `sign-macos-installer-cert` | "" | MacOS Installer Certificate |
| `sign-macos-installer-cert-password` | "" | MacOS Installer Certificate Password |
| `sign-windows-cert` | "" | Windows Signing Certificate |
| `sign-windows-cert-password` | "" | Windows Signing Certificate Password |

## Example Build

```yaml
name: Wails build
name: Wails Build
on: [push, pull_request]
Expand All @@ -75,16 +73,18 @@ jobs:
fail-fast: false
matrix:
build: [
{name: 'App', platform: linux/amd64, os: ubuntu-latest},
{name: 'App', platform: windows/amd64, os: windows-latest},
{name: 'App', platform: darwin/universal, os: macos-latest}
{name: "App", platform: linux/amd64, os: ubuntu-latest},
{name: "App", platform: windows/amd64, os: windows-latest},
{name: "App", platform: darwin/universal, os: macos-latest}
]
runs-on: ${{ matrix.build.os }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: recursive
- uses: The-Egg-Corp/[email protected]
- uses: The-Egg-Corp/[email protected]
with:
build-name: ${{ matrix.build.name }}
build-platform: ${{ matrix.build.platform }}
Expand All @@ -94,7 +94,7 @@ jobs:
You need to make two gon configuration files, this is because we need to sign and notarize the .app before making an installer with it.

```yaml
- uses: The-Egg-Corp/wails-build-action@v1.2
- uses: The-Egg-Corp/wails-build-action@v1.3
with:
build-name: wailsApp
sign: true
Expand Down
38 changes: 19 additions & 19 deletions action.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,43 +67,43 @@ inputs:
deno-version:
description: "Version of Deno to use"
required: false
default: "v1.20.x"
default: "v1.x"
sign-macos-app-id:
description: "MacOS Application Certificate id"
description: "MacOS Application Certificate ID"
required: false
default: ''
default: ""
sign-macos-apple-password:
description: "MacOS Apple password"
description: "MacOS Apple Password"
required: false
default: ''
default: ""
sign-macos-app-cert:
description: "MacOS Application Certificate"
required: false
default: ''
default: ""
sign-macos-app-cert-password:
description: "MacOS Application Certificate Password"
required: false
default: ''
default: ""
sign-macos-installer-id:
description: "MacOS Installer Certificate id"
description: "MacOS Installer Certificate ID"
required: false
default: ''
default: ""
sign-macos-installer-cert:
description: "MacOS Installer Certificate"
required: false
default: ''
default: ""
sign-macos-installer-cert-password:
description: "MacOS Installer Certificate Password"
required: false
default: ''
default: ""
sign-windows-cert:
description: "Windows Signing Certificate"
required: false
default: ''
default: ""
sign-windows-cert-password:
description: "Windows Signing Certificate Password"
required: false
default: ''
default: ""

runs:
using: "composite"
Expand Down Expand Up @@ -189,24 +189,24 @@ runs:
shell: bash

# Package and Sign MacOS
- name: Import Code-Signing Certificates for macOS
- name: Import Code-Signing Certificates for MacOS
if: runner.os == 'macOS' && inputs.sign && startsWith(github.ref, 'refs/tags/')
uses: Apple-Actions/import-codesign-certs@v1
uses: Apple-Actions/import-codesign-certs@v3
with:
keychain-password: ${{ inputs.sign-macos-apple-password }}
p12-file-base64: ${{ inputs.sign-macos-app-cert }}
p12-password: ${{ inputs.sign-macos-app-cert-password }}

- name: Import Code-Signing Certificates for macOS Installer
- name: Import Code-Signing Certificates for MacOS Installer
if: runner.os == 'macOS' && inputs.sign && startsWith(github.ref, 'refs/tags/')
uses: Apple-Actions/import-codesign-certs@v1
uses: Apple-Actions/import-codesign-certs@v3
with:
keychain-password: ${{ inputs.sign-macos-apple-password }}
p12-file-base64: ${{ inputs.sign-macos-installer-cert }}
p12-password: ${{ inputs.sign-macos-installer-cert-password }}
create-keychain: false

- name: Sign our macOS binary
- name: Sign our MacOS binary
if: runner.os == 'macOS' && inputs.sign && startsWith(github.ref, 'refs/tags/')
shell: bash
working-directory: ${{ inputs.app-working-directory }}
Expand Down Expand Up @@ -237,7 +237,7 @@ runs:
run: |
productbuild --component ${{ inputs.app-working-directory }}/build/bin/${{inputs.build-name}}.app ${{ inputs.app-working-directory }}/build/bin/${{inputs.build-name}}.pkg
- name: Notarising Installer and zip
- name: Notarising Installer and ZIP
if: runner.os == 'macOS' && inputs.sign && startsWith(github.ref, 'refs/tags/')
shell: bash
working-directory: ${{ inputs.app-working-directory }}
Expand Down

0 comments on commit 8d04aa0

Please sign in to comment.