Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blatant Reference Hardsuits and more #130

Merged
merged 11 commits into from
Jan 6, 2025

Conversation

Hobbitmax
Copy link

Description

Description.
Federal requested several changes which i made.
Including a new hardsuit thats not at all a reference nope no sirie
Two new hats.
And also a new piece of shiny cookware.

TODO

  • Merge the PR
  • Make the PR

Media

Example Media Embed


Changelog

🆑

  • add: Made the HeckFallers Hardsuit Exist
  • add: The Unusual Hat,
  • add: The Finders Hat
  • add: The Frying pan (and in gold too)
  • tweak: Reverted EEs change to the shock collar to be more evil
  • add: Shoes and socks, At federals request

put shit in the arc namespace. probably.
Unkinkied the shock collar,
Added the Frying Pan, and Gold Frying pan as weapons.
Also a new hardsuit.
And some other fun bullshit i guess. lot of this was made by federals request.
Copy link
Collaborator

@bruhmogus bruhmogus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these NEED to be changed before merge for legal reasons

parent: ClothingHeadBase
id: ClothingHeadHatkid
name: finder's hat
description: A fancy little hat to wear when looking for time
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAGH PUNCTUATION!!!!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i copy and pasted you fuck you should of said finders hat instead of finder's hat then

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a: add an apostrophe in finders to make it finder's
b: add a period in the description

thats all.
@Hobbitmax
Copy link
Author

that commit should fix federals gripes about copywrites.

@Hobbitmax
Copy link
Author

merge unconflicted. probably

@Hobbitmax Hobbitmax requested a review from bruhmogus January 6, 2025 00:44
@Erisfiregamer1
Copy link
Collaborator

Conflict in battery_guns.yml needs resolving otherwise gucci

parent: ClothingHeadBase
id: ClothingHeadHatkid
name: finder's hat
description: A fancy little hat to wear when looking for time
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a: add an apostrophe in finders to make it finder's
b: add a period in the description

@Hobbitmax
Copy link
Author

Conflict in battery_guns.yml needs resolving otherwise gucci

Cant try and resolve it. Dont have write access. pretty sure its just "use masters version" as opposed to ours. But let me fix federals issues.

there you go.
@Erisfiregamer1
Copy link
Collaborator

Conflict in battery_guns.yml needs resolving otherwise gucci

Cant try and resolve it. Dont have write access. pretty sure its just "use masters version" as opposed to ours. But let me fix federals issues.

You MOVED THE FILE on your branch hence the conflict. Either move it back or follow Git's instructions to merge.

@Hobbitmax
Copy link
Author

Hobbitmax commented Jan 6, 2025

Conflict in battery_guns.yml needs resolving otherwise gucci

Cant try and resolve it. Dont have write access. pretty sure its just "use masters version" as opposed to ours. But let me fix federals issues.

You MOVED THE FILE on your branch hence the conflict. Either move it back or follow Git's instructions to merge.

where the FUCK would i move it back to. Also i do not get instructions to fix it because i do not have write access to resolve conflicts
image

Move it back to wherever it was I guess! Check the Files Changed tab in Github. Here's the instructions Git gave me:

image

@Hobbitmax Hobbitmax requested a review from bruhmogus January 6, 2025 01:07
@bruhmogus bruhmogus dismissed their stale review January 6, 2025 01:10

literally nothing changed since last time

@Hobbitmax
Copy link
Author

Conflict in battery_guns.yml needs resolving otherwise gucci

Cant try and resolve it. Dont have write access. pretty sure its just "use masters version" as opposed to ours. But let me fix federals issues.

You MOVED THE FILE on your branch hence the conflict. Either move it back or follow Git's instructions to merge.

where the FUCK would i move it back to. Also i do not get instructions to fix it because i do not have write access to resolve conflicts image

Move it back to wherever it was I guess! Check the Files Changed tab in Github. Here's the instructions Git gave me:

image

those are instructions on how to OPEN THE EDITOR ITSELF... im going to look at files changed myself then i guess.

Copy link
Collaborator

@bruhmogus bruhmogus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

nightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmarenightmare
@Hobbitmax
Copy link
Author

FUCK IT. that should of fixed it. I THINK. HELL if i know what was wrong. apparently "FILE name changed" was all that was different and maybe thats a folder. i don't goddamn know

@Erisfiregamer1
Copy link
Collaborator

Resources/Prototypes/_Arc/Entities/Objects/Weapons/Battery/battery_guns.yml is the path you need to move it to I think

Resources/Prototypes/_Arc/Entities/Objects/Weapons/Guns/battery_guns.yml is the path YOU moved it to.

@Hobbitmax
Copy link
Author

Hobbitmax commented Jan 6, 2025

Resources/Prototypes/_Arc/Entities/Objects/Weapons/Battery/battery_guns.yml is the path you need to move it to I think

Resources/Prototypes/_Arc/Entities/Objects/Weapons/Guns/battery_guns.yml is the path YOU moved it to.

where "you moved it to" and where it needs to be was where it was before commit: unmergeconflict i guess and it still conflicted.

The first time you moved it was Resources/Prototypes/_Arc/Entities/Objects/Weapons/Guns/Battery/battery_guns.yml

The next move was to
Resources/Prototypes/_Arc/Entities/Objects/Weapons/Guns/battery_guns.yml

GITHUB says the conflict is Resources/Prototypes/_Arc/Entities/Objects/Weapons/Battery/battery_guns.yml

it was the folder being batterys instead of battery. i am going to murder someone.
@Hobbitmax
Copy link
Author

i swear to god it was because the folder was battery and not batterys. i am going to murder someone

@Hobbitmax
Copy link
Author

oh yeah and also theres fucking gulos changes which is F U N (its not i want to die)

@Erisfiregamer1
Copy link
Collaborator

Dusty I am starting to question your ability to read

i swear to god it was because the folder was battery and not batterys. i am going to murder someone

❌ Try again!

@Hobbitmax
Copy link
Author

Safe to merge. solve the conflict by favoring my modifcation of the folders over master branches.

@Erisfiregamer1
Copy link
Collaborator

You merged the changes fine but you still cant move the file, I said you have to move it back for a reason

Safe to merge. solve the conflict by favoring my modifcation of the folders over master branches.

❌ Try again! (I can't do that from Github)

they will not find the body.
why are we still here. just to suffer.
@Hobbitmax
Copy link
Author

p a i n.

@Erisfiregamer1
Copy link
Collaborator

The Pain:tm: is over now, you can sleeb

@Erisfiregamer1 Erisfiregamer1 merged commit a0a39c6 into The-Arcadis-Team:master Jan 6, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants