Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missing items display_id #1446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geo-tp
Copy link
Collaborator

@geo-tp geo-tp commented Oct 6, 2024

Resolving Item Display Issues Based on ItemDisplayInfo

Automated using a script to compare data between 1.2 and 0.5.3

  1. Retrieve all items where display_id > 11802 and entry < 6439.
  2. Iterate over each of them and retrieve the vmangos.ItemDisplayInfo related to the display_id for each entry.
  3. Compare vmangos.ItemDisplayInfo with alpha_dbc.ItemDisplayInfo to find a model in the 0.5.3 range with the exact same model fields.

Note: The icon should not be NULL, or the model will not be updated. This happens when the exact model is found but no icon is associated with the display_id.

Since we know that most of the items were updated because of the icon, it makes sense to use this approach to resolve the remaining display_id entries.

The following fields were compared

['ModelName1', 'ModelName2', 'ModelTexture1', 'ModelTexture2', 'Texture1', 'Texture2', 'Texture3', 'Texture4', 'Texture5', 'Texture6', 'Texture7', 'Texture8']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant