Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various enhancements and bug fixes #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

richardkchapman
Copy link

Added multi-tile support, support for vertical printing, support for printing a "crust" (works for vertical printing) and a few miscellaneous fixes/changes that helped me get my print to work.

Richard Chapman and others added 4 commits December 13, 2014 17:08
Add compensation for longitude

Fix error if width and height not equal

Signed-off-by: Richard Chapman <[email protected]>
Separate crust mode and verticall mode

Signed-off-by: Richard Chapman <[email protected]>
More options

Signed-off-by: Richard Chapman <[email protected]>
@ThatcherC
Copy link
Owner

Hi Richard,
Those are a ton of changes! I haven't read through all the differences yet,
but tile-crossing is a big step.
I have a few questions on your additions:

  1. What is the vertical option? I'm not sure what it does.
  2. Is the crust option a certain height added to the bottom of the model?
    If so, you might want to check out the 'newfeatures' branch of the project
  • it adds a 'baseHeight' parameter to make printing easier.
  • The hole-fixing part looks good, but how does it fair on large void
    regions, like Mt. Everest? I have considered finding or developing an
    algorithm to fix the whole dataset, rather than each model as it is made.
    In the mean time, averaging for holes is a good addition.

I might not merge you changes soon. I currently in a negotiation to partner
with a 3D printing company and I'm not sure how they want to handle extra
contributions yet. I can assure you, though, that I will incorporate them
into the project at some point, probably six weeks at the most.

Thanks a lot for you additions to the project!
Thatcher

On Sat, Dec 13, 2014 at 2:53 PM, Richard Chapman [email protected]
wrote:

Added multi-tile support, support for vertical printing, support for
printing a "crust" (works for vertical printing) and a few miscellaneous

fixes/changes that helped me get my print to work.

You can merge this Pull Request by running

git pull https://github.com/richardkchapman/Terrain2STL master

Or view, comment on, or merge it at:

#2
Commit Summary

  • Add vertical option
  • Add argument parsing
  • Better hole fixing
  • Added support for spanning lat/long tile boundaries

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#2.

@richardkchapman
Copy link
Author

The crust option makes the thickness of the model constant - i.e. the bottom surface is not flat but instead is a constant distance from the top surface. It makes for an interesting effect (and uses less plastic!).

I have not tried the hole fixing anywhere other than the one area I was trying to print (in the English Lake District). It was good enough to fix up that area, but might not completely fix up other areas. Shouldn't make anything any worse though.

Really the code should be taking an average of the non-void surrounding area of whatever size is necessary to find some non-void data, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants