-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASTextNode2] Integrate Google's changes to ASTN2 and accessibility #2017
base: master
Are you sure you want to change the base?
Commits on Aug 4, 2021
-
[ASTextNode2] Second try to merge Google's ASTextNode2 changes
This time I included the accessibility changes, which required adding some of the new accessibility features in other parts of the code. Note, there are cases where not all of the accessibility was brought over because that was supposed to be covered in a separate PR made by someone from Google.
Configuration menu - View commit details
-
Copy full SHA for 721aecf - Browse repository at this point
Copy the full SHA 721aecfView commit details
Commits on Aug 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c691684 - Browse repository at this point
Copy the full SHA c691684View commit details
Commits on Nov 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0d01fa6 - Browse repository at this point
Copy the full SHA 0d01fa6View commit details
Commits on Nov 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1ed7f41 - Browse repository at this point
Copy the full SHA 1ed7f41View commit details
Commits on Dec 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1564bb3 - Browse repository at this point
Copy the full SHA 1564bb3View commit details -
Google seems to have improved truncating in ASTN2
This test passes on master but fails on the merge branch. Looking at the snapshot difference, it appears that google figured out a way to get more characters in before truncating. The text is still within its provided max size.
Configuration menu - View commit details
-
Copy full SHA for a5139a7 - Browse repository at this point
Copy the full SHA a5139a7View commit details -
Rename ASNavigationController to ASDKNavigationController to fix name…
… collision (TextureGroup#2020) As of iOS15 the AuthenticationServices framework has a class named `ASNavigationController`. We need to rename our `ASNavigationController` to protect against undefined behavior. Note: This change was based on this PR TextureGroup#2014. We were slow in merging it and the author has not replied, so I'm making a new one to get this landed.
Configuration menu - View commit details
-
Copy full SHA for 624caad - Browse repository at this point
Copy the full SHA 624caadView commit details -
[3.1.0] Create new version of ASDK (TextureGroup#2021)
With the breaking change of renaming ASNavigationController to ASDKNavigationController, we have released a new version of Texture. Please see `ThreeMigrationGuide.md` for how to handle the breaking changes in 3.1.0.
Configuration menu - View commit details
-
Copy full SHA for cb12cfb - Browse repository at this point
Copy the full SHA cb12cfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d82544 - Browse repository at this point
Copy the full SHA 3d82544View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64c49d2 - Browse repository at this point
Copy the full SHA 64c49d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59431f8 - Browse repository at this point
Copy the full SHA 59431f8View commit details -
Remove AssetsLibrary dependency for tvOS (TextureGroup#2034)
- The framework isn't available on tvOS. This causes CocoaPods linting to fail which prevented me from pushing the new release out. - One way to fix this is to have a different `default_subspecs` for tvOS that doesn't have AssetsLibrary subspec, but per-platform `default_subspecs` doesn't seem to be supported by CocoaPods. So I updated the subspec itself to only depend on the framework for iOS. This means the subspec is empty/useless for tvOS (and other platforms FWIW). - Tested with `pod spec lint Texture.podspec`. - Fixes TextureGroup#1992 and part of TextureGroup#1549. Also unblocks 3.1.0 release. - For the long term, we can remove the subspec entirely when iOS 9 is deprecated (TextureGroup#1828).
Configuration menu - View commit details
-
Copy full SHA for da7a706 - Browse repository at this point
Copy the full SHA da7a706View commit details
Commits on Dec 3, 2021
-
Try to fix the CI (TextureGroup#2047)
It looks like github updated so that `macos-latest` is now macos-11. It can't find Xcode_11_5. Let's try to set the runs-on version explicitly and see if some magic happens. also allow warnings for podlint because that started failing too
Configuration menu - View commit details
-
Copy full SHA for b9f1713 - Browse repository at this point
Copy the full SHA b9f1713View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f58cfc - Browse repository at this point
Copy the full SHA 5f58cfcView commit details