Decode alternative image types in ASImageNode at render time #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to confirm, this change requires the PINRemoteImage change be merged and released? |
Yes, that's right. Could add an additional build directive into PINRemoteImage (like #PINCustomDecoders or something) so that they can go in independently. WDYT? |
|
I don't think that's necessary, PINRemoteImage is due a release soon anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support at the Texture level for decoding additional image formats at render time once the final image size is known
The Cartfile changes are because ASPINRemoteImageDownloader currently references API's that don't exist in the older version of PINRemoteImage
See pinterest/PINRemoteImage#602 for corresponding PINRemoteImage change
Upstreamed contribution from Google's fork of Texture