Add BSP version to the names of output tars and wics #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuhaas22
requested review from
sskartheekadivi,
glneo,
cshilwant and
khasim-syed
as code owners
jsuhaas22
force-pushed
the
include-version-in-output
branch
11 times, most recently
from
78c486d to
8eeca31
Compare
|
@jsuhaas22 Ideally we should integrate #61 before this PR & then rebase on top to ensure the workflows tests Currently the workflows would still pick |
jsuhaas22
force-pushed
the
include-version-in-output
branch
2 times, most recently
from
6f8dc4c to
66c2c51
Compare
glneo
reviewed
Nov 19, 2024
create-wic.sh
Outdated
|
|
||
| distro_codename=($(read_build_config ${BUILD} distro_codename)) | ||
| bsp_version=($(read_bsp_config ${distro_codename} bsp_version)) | ||
| BUILD_FULL="${BUILD}-${bsp_version}" |
There was a problem hiding this comment.
Might be more clear what file is being used if you drop BUILD_FULL and just use ${BUILD}-${bsp_version} directly below.
jsuhaas22
force-pushed
the
include-version-in-output
branch
from
66c2c51 to
893e3e2
Compare
glneo
reviewed
Nov 20, 2024
build.sh
Outdated
| @@ -60,6 +61,7 @@ do | |||
| echo "machine: ${machine}" | |||
| echo "bsp_version: ${bsp_version}" | |||
| echo "distro: ${distro}" | |||
| echo "distro_bsp_version: ${distro_bsp_version}" | |||
There was a problem hiding this comment.
You already print distro above, why not just print bsp_version here.
glneo
reviewed
Nov 20, 2024
build.sh
Outdated
| @@ -68,9 +70,9 @@ do | |||
|
|
|||
| validate_build ${machine} ${bsp_version} ${distro_codename}/${distro}.yaml | |||
|
|
|||
| generate_rootfs ${distro} ${distro_codename} ${machine} | |||
| generate_rootfs ${distro} ${distro_codename} ${machine} ${distro_bsp_version} | |||
There was a problem hiding this comment.
You are already passing in the distro, you should only need to pass in the bsp_version. You can concat inside the function called here as needed.
There was a problem hiding this comment.
Made these changes @glneo
There is a requirement to include the BSP versions in the names of the images we distribute. So include the version in the name. Signed-off-by: Suhaas Joshi <[email protected]>
Since we are now appending the BSP version in image's/tar's names, Github Actions also needs to be updated to work with a file which has the BSP version included in it. So update Github Actions to work with the new naming scheme. Signed-off-by: Suhaas Joshi <[email protected]>
jsuhaas22
force-pushed
the
include-version-in-output
branch
from
893e3e2 to
a41ce24
Compare
glneo
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a requirement to include the BSP versions in the names of the images we distribute. So include the version in the name.