seva-adocker: Reduce size of Docker Images #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This app is no longer maintained in seva-design-gallery. Hence, remove it's Dockerfile and README. Signed-off-by: Chirag Shilwant <[email protected]>
- Keep bare minimum packages in demo_baseline which are required to build QT application from sources. - This will help in reducing the size of demo_baseline docker image. Signed-off-by: Chirag Shilwant <[email protected]>
- Some packages are needed only while building Thermostat Demo (i.e at Compile time). Hence, remove those packages from the docker image right after we compile the Thermostat demo. - This will help in reducing the size of Thermostat Demo Docker Image. - Use --platform as wayland while running the Thermostat Demo Application. Signed-off-by: Chirag Shilwant <[email protected]>
- Earlier we used to push baseline & apps together to container registry. This should be avoided as apps are built on top of baseline. - Hence, build & push baseline to container registry before building & pushing apps. Signed-off-by: Chirag Shilwant <[email protected]>
sskartheekadivi
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.