-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update the how_to_check_device_tree_info guide #89
Conversation
New warnings found with rstcheck:
|
source/linux/How_to_Guides/FAQ/How_to_Check_Device_Tree_Info.rst
Outdated
Show resolved
Hide resolved
source/linux/How_to_Guides/FAQ/How_to_Check_Device_Tree_Info.rst
Outdated
Show resolved
Hide resolved
source/linux/How_to_Guides/FAQ/How_to_Check_Device_Tree_Info.rst
Outdated
Show resolved
Hide resolved
source/linux/How_to_Guides/FAQ/How_to_Check_Device_Tree_Info.rst
Outdated
Show resolved
Hide resolved
Fix the examples in this guide by implementing the following: - Switch from xxd to hexdump since xxd is no longer packaged in fs - Add examples and logs for am62* devices - Update code blocks to .. code-block:: console format - Make the document more generic by using <machine> for device in logs Signed-off-by: Judith Mendez <[email protected]>
New warnings found with rstcheck:
|
@jsuhaas22 @jeevantelukula Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all code blocks,
Better to have a single convention for the entire section.
If it's a common section, use root@<machine>
if it's under ifconfig for single platform, use the root@<yocto machine name>
@cshilwant , did you read @StaticRocket and my conversation before? We agreed that the logs are device specific, if we use a generic name in the logs, then customers will expect to see the exact same log on any device. In this case, I believe it is best to leave j721e logs or am62x logs in the examples, that way they know the example is for which exact device |
Author has provided the justification
Fix the examples in this guide by implementing the following: